Fix missing trailling commas #9238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 10, 2018
There was a problem hiding this comment.
@DylanDelobel thanks a lot for taking care of this! It looks great and there's only one minor issue. Cheers.
quick_tour/the_view.rst
Outdated
| @@ -68,7 +68,7 @@ on its type: | |||
|
|
|||
| {# 1. Simple variables #} | |||
| {# $this->render('template.html.twig', array( | |||
| 'name' => 'Fabien') | |||
| 'name' => 'Fabien'), | |||
There was a problem hiding this comment.
This looks wrong ... maybe keep the new comma here ... but move the closing parenthesis to the next line:
{# $this->render('template.html.twig', array(
'name' => 'Fabien',
)) #}
|
@DylanDelobel thanks! It's merged now. If you want to keep fixing this in the other branches (2.8, 3.4, 4.0 and master ... 3.3 is no longer maintained) please wait until we merge these changes up to the rest of branches. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Feb 10, 2018
This PR was squashed before being merged into the 2.7 branch (closes #9238). Discussion ---------- Fix missing trailling commas Here is it @javiereguiluz Fix missing trailling commas for 2.7 #8325 Commits ------- de95293 Fix missing trailling commas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is it @javiereguiluz
Fix missing trailling commas for 2.7 #8325